-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes invalid monitor range bug & adds range validation #17
Fixes invalid monitor range bug & adds range validation #17
Conversation
Please could you fix some little bugs in this request?
|
I've fixed 1 & 3. However, I don't see what you mean by "one-off errors in the comparisons against the top of memory". From the easy6502 page:
The reason why I'm using |
Oops, you are quite right - it was my own out by one error. Noting that I have seen your request to use start and end instead of start and length, I wonder if it would be clearer to use |
I agree. I've made the changes. I think this way (the way you proposed), is a lot easier to think about. |
Fixes invalid monitor range bug & adds range validation
That's great - merged. I'm trying to keep this (original) fork as stable as possible, in a strict maintenance-only mode. I intend to put a note into the page and the readme to promote any other actively-developed forks. The idea is that anyone landing at http://skilldrick.github.io/easy6502/ will have something worthwhile to use, and also have pointers to more advanced developments. The various active forks will of course be free to share their innovations amongst themselves, and no-one need be held up by my caution or inattention. |
#11 I'd like to get fixed, but yes please, let's regard the others as enhancements to your fork. |
Fixes #16.
Monitor now displays a warning message about an invalid range instead of hanging browser.
Also adds basic validation to monitor start/length inputs. If a negative value is entered for either or if
start + length
is beyond the 6502's 64 KiB of memory, the fields will turn red to indicate the problem.